wordpress-mobile / wordpress-mobile/MediaEditor-iOS
Filers: Image appears skewed after applying filter.
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 54
- Forks
- 6
- Avg merge
- 8h 43m
- Merged PRs (30d)
- 5
Description
Expected behavior
To apply a filter to an image, and see the filtered image with the same aspect ratio and not skewed.
Actual behavior
Applying a filter (in the iPhone X simulator) results in the filtered image appearing skewed, as if the UIImageView displaying the image had its content mode set to fill vs aspect-fit.
Steps to reproduce the behavior
Choose to edit a UIImage (I also reproduced with remote images).
Select the filter option.
Apply a filter like Sepia
Observe the image is now skewed.
Bonus, rotate the device and notice how the image stretches. This is what has me thinking about the content mode.
Tested on [device], iOS [version], WPiOS [version]
iPhone X Simulator,
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Reproduce the filter flow in the iPhone X simulator, including device rotation, then trace the image display path to compare the pre-filter and post-filter aspect ratios. Done means filtered images retain their aspect ratio and do not stretch after rotation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100