wordpress-mobile / wordpress-mobile/GutenbergKit
Deduplicate `showSpinner()` invocation alongside `loadEditor()`
Open
Nobody has claimed this yet.
[Type] Code Quality
Good First Issue
- Dominant language
- JavaScript
- Stars
- 29
- Forks
- 6
- Avg merge
- 1d 9h
- Merged PRs (30d)
- 41
Description
This may be duplicative since showSpinnerPhase() is invoked within loadEditor(). Remove it?
Originally posted by @dcalhoun in https://github.com/wordpress-mobile/GutenbergKit/pull/326#discussion_r2829592044
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the showSpinner() and loadEditor() entry points and inspect how showSpinnerPhase() is invoked within loadEditor(). Remove the duplicated invocation if confirmed, then verify that the editor still displays its spinner during loading and that existing checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100