wordpress-mobile / wordpress-mobile/AztecEditor-iOS

Unable to determinate toolbar button status programatically

Open
#837 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Automated Testing [Type] Tech Debt / Tech Task
Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Description

For automated tests (and for VoiceOver users) we need to be able to check toolbar status programmatically. For this, we can change expand button label to reflect it's status i.e. formatToolbarButton && formatToolbarButtonExpanded

Also, toolbar expand button don't have an accessibility selector, which makes it hard to locate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the toolbar expand button implementation and inspect how its label and accessibility properties are set. Update the label so expanded and collapsed states are distinguishable and add an accessibility selector; done means automated tests and VoiceOver users can identify the button and its current status.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
accessibility, mobile
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.