wordpress-mobile / wordpress-mobile/AztecEditor-iOS

Lists: When changing list style for one list item, change the style for the whole list

Open
#730 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

[Type] Bug
Dominant language
Swift
Stars
669
Forks
153
Avg merge
11h 27m
Merged PRs (30d)
4

Description

Expected behavior

I expect that I should be able to change a list style with these steps:

  1. Create a list in one style (e.g. unordered).
  2. Select part of the list, such as a single list item.
  3. Select a new list style (e.g. ordered).

I expect that this will change the entire list style, not just the style for the selected list item. This is how it works in Aztec for Android, Calypso, and (for comparison) Google Docs.

Actual behavior

When I select a single list item and select a new style, it only change the style for the selected list item.

Steps to reproduce the behavior
  1. Create an unordered list with multiple items.
  2. Select one item in the list.
  3. Select the ordered list button.

Result: The selected list item becomes ordered, but the rest of the list remains unordered.

Tested on iPhone 6, iOS 11.0, WPiOS 8.4.0.20170918
Different behavior discovered in automated UI tests for lists in iOS & Android

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with an unordered list, a single selected item, and the ordered list button on iOS. Compare the result with the expected behavior: changing one selected item should change the style of the entire list, and the existing automated list UI tests should cover the completed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.