wordpress-mobile / wordpress-mobile/AztecEditor-iOS
captionStyler not used
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 669
- Forks
- 153
- Avg merge
- 11h 27m
- Merged PRs (30d)
- 4
Description
According to the comment here, the captionStyler is a closure that "will be executed whenever the TextView needs to set the base style for a caption". We are told we can "Override this to customize the caption styling."
However, overriding the captionStyler appears to have no effect. In fact, I couldn't find anywhere in the TextView class where captionStyler is even accessed again.
To Reproduce
- Set the
captionStyleron aTextView. - Add an attachment with a caption.
Expected behavior
The caption is styled according to the captionStyler.
Actual Behavior
The caption uses the default style.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Aztec/Classes/TextKit/TextView.swift at the captionStyler comment around line 240, then trace caption handling when an attachment is added. Reproduce the issue by setting captionStyler and adding an attachment with a caption. Done means the caption uses the configured styler instead of the default style.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100