wolfi-dev / wolfi-dev/wolfictl

wolfibump doesn't work with different fork repo name

Open
#938 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement needs-triage
Dominant language
Go
Stars
73
Forks
86
Avg merge
7d 7h
Merged PRs (30d)
15

Description

Description

Transferring issue over:

I was trying to use wolfibump with my wolfi-dev/os fork wlynch/wolfi-os, and ran into problems.

There's a lot of code that assumes the default forks name of a repositories.

Currently you get an error like:

2024/02/21 14:22:04 unable to create a pull request: will ignore this execution: branch already exists: while checking if repository is a fork of wolfi-dev/os: checking if repository is a fork: getting repository: GET https://api.github.com/repos/wlynch/os: 404 Not Found []

I tried wiring up a fork repo name flag, which then led me to the error:

2024/02/21 14:39:31 unable to create a pull request: will ignore this execution: branch already exists: a branch named main already exists in wlynch/wolfi-os

which doesn't quite make sense since we'd expect the main branch to exist on all forks.

I then tried setting the --wolfi-packages-repo-branch=wolfibump flag, but that failed because it assumes the same branch name for the fork checkout.

2024/02/21 14:43:15 failed to clone repository https://github.com/wolfi-dev/os.git into /var/folders/83/j7crs0zj5g9_nj3wb9hql9hh0000gn/T/wolfibump410073369: reference not found

Internal

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing wolfibump's repository and branch handling around the fork repository name and the --wolfi-packages-repo-branch flag. Reproduce the failures with a fork named wlynch/wolfi-os and inspect how the main and wolfibump branches are selected. Done means wolfibump can use a fork with a different repository name and distinct branch names without assuming wolfi-dev/os defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.