wolfi-dev / wolfi-dev/wolfictl

some package names can cause issues with `wolfictl check update`

Open
#332 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs-triage
Dominant language
Go
Stars
73
Forks
86
Avg merge
7d 7h
Merged PRs (30d)
15

Description

Description

I think wolfictl might have a bug around here (or maybe when it trims the suffix?) if the filename is like py3-ruamel.yaml.yaml.

I noticed during this CI failure. This basically causes the wrong filename (py3-ruamel.yaml instead of py3-ruamel.yaml.yaml) to get passed into os.ReadFile.

Here's a simple PoC: https://go.dev/play/p/yAUSuMaR6TQ

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in pkg/checks/update.go at the referenced lines around filename handling and suffix trimming. Reproduce the py3-ruamel.yaml.yaml case using the linked Go playground PoC, then verify that wolfictl check update passes the complete filename to os.ReadFile without breaking other package names.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.