wjmelements / wjmelements/scripts

Without a Reviewers line, cpr still tries to set reviewers

Open
#17 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
16
Forks
3
PR merge metrics
No merged PRs in 30d

Description

We should skip the set-reviewers step when no reviewers are supplied.

From the output of cpr without a reviewers line:

Sending pull request...
https://github.com/dydxprotocol/protocol/pull/435 (copied to clipboard)
Setting reviewers...
Validation Failed
Could not add requested reviewers to pull request.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the cpr workflow's reviewer-setting step and reproduce the command without a reviewers line. Done means cpr skips that step and completes pull request creation without the reviewer validation error.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.