Modal props missing from Hint component
Open
Nobody has claimed this yet.
bug
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 748
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 1
Description
Description
There's no ability to pass modal props to the Hint component and this causes an issue with my app due to needing to add supportedOrientations
Related to
- Components
- Demo
- Docs
- Typings
Steps to reproduce
- Set up an app that is locked to landscape. For example in expo set this value in your app config:
orientation: "landscape" - Add a hint component that uses a modal. This happens to me as long as I provide the prop
onBackgroundPressi.e. I don't need to passuseModalto get this error - On dismissing the hint, see the following error
Expected behavior
Allow passing modalProps, similar to the Dialog component
Environment
expo: ~54.0.25
react-native-ui-lib: 8.2.2
uilib-native: 5.0.1
Affected platforms
- Android
- iOS
- Web
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Hint component and compare its modal handling with the Dialog component, focusing on how modal props are exposed. Reproduce the issue in an iOS landscape-locked Expo app with onBackgroundPress, then verify that passing modalProps such as supportedOrientations prevents the dismissal error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100