wix / wix/react-native-ui-lib

8.0 ios build issue

Open
#3,841 14 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
7.2k
Forks
748
Avg merge
2d 18h
Merged PRs (30d)
1

Description

Description

just build using xcode for ios. the xcode tell that

 
/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:5: Use of undeclared identifier 'RCTAppDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:21: Use of undeclared identifier 'appDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:51: Expected expression

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:36: Use of undeclared identifier 'RCTAppDelegate'

/node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:53: Missing '[' at start of message send expression

 /node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:152:94: Expected ']'

 /node_modules/react-native-ui-lib/lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m:153:19: Use of undeclared identifier 'appDelegate'


Steps to reproduce

just build using xcode

More Info

I think we need to add s.dependency 'React-RCTAppDelegate' into the pod file . like below

Code snippet
require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'lib/package.json')))

Pod::Spec.new do |s|
  s.name         = "ReactNativeUiLib"
  s.version      = package['version']
  s.summary      = "React Native UI Library"

  s.authors      = "Wix.com"
  s.homepage     = package['homepage']
  s.license      = package['license']
  s.platforms    = { :ios => "9.0", :tvos => "9.2" }

  s.module_name  = 'ReactNativeUiLib'

  s.source       = { :git => "https://github.com/wix/react-native-ui-lib.git", :tag => "#{s.version}" }
  s.source_files  = "lib/ios/**/*.{h,m}"

  s.dependency 'React'
  s.dependency 'React-RCTAppDelegate'
  s.frameworks = 'UIKit'
end


Environment
  • React Native version: 0.81.5
  • React Native UI Lib version: 8.0.0
Affected platforms
  • Android
  • iOS
  • Web

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the iOS build with React Native 0.81.5 and React Native UI Lib 8.0.0, then inspect lib/ios/reactnativeuilib/keyboardinput/rctcustomInputcontroller/RCTCustomInputControllerTemp.m around lines 152-153. Check the podspec dependency shown in the issue and verify that the Xcode build completes without the RCTAppDelegate errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c, react-native
Domain
build-system, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.