wix / wix/react-native-ui-lib

Not Scrollview inside renderSheet

Open
#3,396 2 comments 0 reactions 1 assignee View on GitHub

@adids1221 is already working on this.

Since Dec 17, 2024.

  • #3462 by @adids1221 — closed without merging
feature request waiting-for-response WIP
Dominant language
TypeScript
Stars
7.2k
Forks
748
Avg merge
2d 18h
Merged PRs (30d)
1

Description

Description

Inside ActionSheet on Android not possible scrollview for much items.

Related to
  • [x ] Components
Steps to reproduce

Add more 50 items in options

Expected behavior

Scroll items

Suggested

I am suggest add ScrollView inside renderSheet for resolve bug

renderSheet() {
    const {
      renderTitle
    } = this.props;
    const {
      containerStyle
    } = this.props;
    return <View style={[styles.sheet, containerStyle]}>
        {_isFunction(renderTitle) ? renderTitle() : this.renderTitle()}
        <ScrollView>
            {this.renderActions()}
        </ScrollView>
      </View>;
  }
Affected platforms
  • [x ] Android

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.