wix / wix/react-native-ui-lib

Dark mode view modifiers no longer working

Open
#2,127 43 comments 0 reactions 1 assignee View on GitHub

@lidord-wix is already working on this.

Since Aug 18, 2022.

bug
Dominant language
TypeScript
Stars
7.2k
Forks
748
Avg merge
2d 18h
Merged PRs (30d)
1

Description

Description

Dark mode no longer works with view modifiers. Regardless of device scheme, the view background colors will be "light".

Related to
  • Components
  • Demo
  • Docs
  • Typings
Steps to reproduce
  1. Load light and dark schemes using Colors.loadSchemes.
  2. Add background color modifier to any view
  3. Switch from light to dark color scheme on device
  4. Views stay light

More Info

I've traced it down to this commit, where the default scheme was changed from default to light. Currently I have patched the package to change it back to default and it works.

Environment
  • React Native: 0.68.2
  • React Native UI Lib: 6.18.0
Affected platforms
  • Android
  • iOS
  • Web

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.