wix / wix/react-native-navigation
"No package name found"
Nobody has claimed this yet.
- Dominant language
- MDX
- Stars
- 13.2k
- Forks
- 2.6k
- Avg merge
- 6d 2h
- Merged PRs (30d)
- 1
Description
What happened?
After upgrading react-native-navigation from 7.39.2 to 7.40.1, builds with React Native 0.70.x (or older?) fail:
error Failed to build the app: No package name found. We couldn't parse the namespace from neither your build.gradle[.kts] file at node_modules/react-native-navigation/lib/android/app/build.gradle nor your package in the AndroidManifest at node_modules/react-native-navigation/lib/android/app/src/main/AndroidManifest.xml.
This breaking change appears to have been introduced in https://github.com/wix/react-native-navigation/commit/6439f6858110fe79b7f9260b91f84dfd6e0e904d.
What was the expected behaviour?
No response
Was it tested on latest react-native-navigation?
- I have tested this issue on the latest react-native-navigation release and it still reproduces.
Help us reproduce this issue!
No response
In what environment did this happen?
React Native Navigation version: 7.40.1
React Native version: 0.70.15
Node version: 18.19.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing commit 6439f6858110fe79b7f9260b91f84dfd6e0e904d and the package-name parsing for node_modules/react-native-navigation/lib/android/app/build.gradle and its AndroidManifest.xml. Reproduce with React Native Navigation 7.40.1 and React Native 0.70.15; done means the build no longer reports “No package name found.”
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, react-native
- Domain
- build-system, mobile
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100