wix / wix/react-native-navigation

App crashes with more than 5 tabs

Open
#7,876 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs triage type: accepted/bug
Dominant language
MDX
Stars
13.2k
Forks
2.6k
Avg merge
6d 2h
Merged PRs (30d)
1

Description

What happened?

The app crashes without any error when I add mroe than 5 tabs

What was the expected behaviour?

Don't crash or at least give an error message that I as developer can handle .
Is there any reason for this limitation and any way to bypass this?

Was it tested on latest react-native-navigation?
  • I have tested this issue on the latest react-native-navigation release and it still reproduces.
Help us reproduce this issue!

https://github.com/wix/react-native-navigation/blob/11efb13da786b9db0989aab15a9f68551ceeb2e7/lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java#L219

In what environment did this happen?

React Native Navigation version: 7.39.2
React Native version: 0.72.13"
Has Fabric (React Native's new rendering system) enabled: (yes/no) yes
Node version: 18.14.2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at lib/android/app/src/main/java/com/reactnativenavigation/viewcontrollers/bottomtabs/BottomTabsController.java:219 and reproduce adding more than five tabs with React Native Navigation 7.39.2, React Native 0.72.13, and Fabric enabled. Use the Android logs to identify the crash; done means the app no longer crashes silently or provides an error that the developer can handle.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, react-native
Domain
mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.