wit-ai / wit-ai/pywit

Add timeout to request

Open
#87 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
353
PR merge metrics
No merged PRs in 30d

Description

Sometimes, adding timeout parameter/default timeout would be helpful since the requests default timeout is None which will hang the application up infinitely
http://docs.python-requests.org/en/master/user/advanced/#timeouts

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the library's request entry points and the Requests timeout documentation linked in the issue. Determine where a timeout parameter or default belongs, then verify that requests no longer uses an unlimited timeout and that callers can override it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.