wireapp / wireapp/wire-webapp

Global infinite retries cause a lot of problems

Open
#17,680 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

type: bug / fix 🐞
Dominant language
TypeScript
Stars
1.2k
Forks
307
Avg merge
17h 44m
Merged PRs (30d)
256

Description

Your Account Type

What steps will reproduce the problem?

Clicking on a contact in the Contacts bar, I want to open a new conversation, but due to network problems, the request fails, and then I click multiple times, which results in multiple retry requests. When the network is restored, multiple conversation appear.

What is the expected behaviour?

Click on a contact multiple times, even if a network problem causes the request to result in, when the network is restored, only one conversation will appear


In api-client, axios-retry is used, so all requests are retried infinite. In fact, it's not just the problem I reported above, but also in other behaviors. This is caused by infinite retries. This issue does not occur in Android/IOS versions.
I don't think global infinite retries are a good design, they should be done only when they are really needed, like sending a message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the api-client configuration where axios-retry is enabled, and reproduce a failed contact request followed by multiple clicks during a network outage. Determine the retry behavior and verify that restoring the network produces only one conversation, with retries limited to explicitly needed operations rather than applied globally.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api, frontend, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.