wintercms / wintercms/wn-user-plugin

Unactivated users get wrong error message

Open
#35 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
13
Forks
20
Avg merge
50m
Merged PRs (30d)
1

Description

Hello,

My users have to activate their account before they can sign in. (Activation type: User)
This is to protect guest users from evil people 'stealing' their accounts. (my way of handling the important text block)

When a user tries to log in, that didn't activate his account yet, they get an error message like
The details you entered did not match our records. Please double-check and try again.

This error is wrong, and it should be something like
You didn't activate your account yet. Please check your email and activate your account.
and, ideally, resend the activation email.

User exists in backend user list, in database and with the onCheckEmail method. So I can change my password, but can never log in because I forgot to activate my account.

The current error message sends me in an infinite loop.

  1. It basically tells me to register
  2. But when registering it says my account already exists
  3. Which suggests me to reset my password
  4. Which when you do, you cannot log in because you are not activated yet
  5. Which resets the whole loop

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the front-end login flow for a User with the activation type enabled, then compare it with the onCheckEmail behavior described in the issue. Done means an unactivated existing user receives a specific activation message instead of the generic credentials error; resending the activation email is identified as a separate requirement if supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.