wintercms / wintercms/wn-debugbar-plugin

Upgrade to v4.0.6 give xDebug issue

Open
#25 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
11
Forks
8
PR merge metrics
No merged PRs in 30d

Description

@LukeTowers
On a working project, if I update to Winter.Debugbar v4.0.6, I ran into a xDebug infinite loop warning when trying to put a model in cache.

How to fix the issue:

        'mail' => [
            // 'full_log' => false
            'timeline' => env('DEBUGBAR_OPTIONS_MAIL_TIMELINE', true),  // Add mails to the timeline
            'show_body' => env('DEBUGBAR_OPTIONS_MAIL_SHOW_BODY', false),
        ],

In this latest case, what I don't understand is having to set the value of options.mail.timeline to true.
If I set it to false, I get the same error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Plugin.php at line 58 and compare the v4.0.5 and v4.0.6 behavior around the winter.debugbar.options.mail configuration. Reproduce the xDebug infinite-loop warning when caching a model, then verify that the fix removes the warning without requiring the mail timeline option to be enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.