wintercms / wintercms/winter

Markdown parser fails in content file when using a content variable as the url

Open
#992 10 comments 0 reactions 1 assignee View on GitHub

@bennothommo is already working on this.

Since Oct 13, 2023.

Dominant language
PHP
Stars
1.5k
Forks
246
Avg merge
19h 2m
Merged PRs (30d)
7

Description

Winter CMS Build

dev-develop

PHP Version

8.1

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

The new markdown parser fails in a contend file when using a content variable in place of a static url.

Steps to replicate

Using this markup in a CMS page:

{% content "test-content.md" url="https://wintercms.com" %}

And this content file:

[click here]({url})
Workaround

Using <a href="{url}">click here</a> tag in the content file works.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.