wintercms / wintercms/winter

Revisions not deleted automatically once related "revisionable" entity is deleted

Open
#315 12 comments 0 reactions 1 assignee View on GitHub

@bennothommo is already working on this.

Since Nov 22, 2021.

Dominant language
PHP
Stars
1.5k
Forks
246
Avg merge
19h 2m
Merged PRs (30d)
7

Description

Winter CMS Build

dev-develop

PHP Version

8.0

Database engine

MySQL/MariaDB

Plugins installed

No response

Issue description

When a revisionable model gets deleted (physically from the database) no related revisions of that model get deleted automatically from system_revisions.

Steps to replicate
  1. Create a revisionable model
  2. Save it to the database
  3. Delete it

Expected result:
All related revisions should be removed

Actual result:
Revisions remain in system_revisions

Workaround

No response

Any further details?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.