Improve deeplinking of tabs when tabs are used within a modal
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.5k
- Forks
- 246
- Avg merge
- 19h 2m
- Merged PRs (30d)
- 7
Description
Winter CMS Build
1.2
PHP Version
8.1
Database engine
MySQL/MariaDB
Plugins installed
No response
Issue description
Hi,
When using tabs inside relation modal, the hash property doesn't get removed from the URL when the modal get dismissed. Thus, clicking on another record in the list make the modal open to the last tab visited.
Thanks.
Steps to replicate
- Configure a relation (in my case a Belongs-To-Many).
- Configure a relation controller.
- Configure a form with some tabs.
- Use the relation modal.
Workaround
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the relation modal flow described in the issue and inspect how the URL hash changes when the modal is dismissed. Done means dismissing the modal removes the previous tab hash, so opening another record does not restore the last visited tab.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- laravel, mariadb, mysql, php
- Domain
- backend, frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100