winglang / winglang/wing

Publish workflow can re-upload previous versions

Open
#4,285 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

✨ enhancement 👷‍♀️ contributor-experience
Dominant language
TypeScript
Stars
5.4k
Forks
215
Avg merge
2h 9m
Merged PRs (30d)
27

Description

See https://github.com/winglang/wing/actions/runs/6312556360/job/17140355016

The commit contained no changes to the npm packages but it built a new package anyways. This seems to cause a problem when publishing to npm, where the version is different but the contents are the same. It's also generally wasteful to publish a new package if nothing changed.

We should skip publishing to npm if the winglang package (or any of its deps) have not changed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the publish workflow referenced by the issue and the job from the linked GitHub Actions run. Trace how the winglang npm package and its dependencies are built and published; done means a commit with no package changes skips publishing while relevant changes still publish correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, typescript
Domain
ci-cd, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.