winglang / winglang/wing

Architecture for LSP completion improvements

Open
#2,005 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

✨ enhancement 👷‍♀️ contributor-experience 📡 language-server needs-discussion
Dominant language
TypeScript
Stars
5.4k
Forks
215
Avg merge
2h 9m
Merged PRs (30d)
27

Description

Feature Spec

Improvements to completions in the LSP typically fall into one of three categories:

  • What contexts exist in which to generate completions and how can we detect that a position is in it?
    • e.g. Requesting completions within the right-hand side of an assignment is distinct from the left-hand side
  • Given a context, what completions should be generated?
  • Given a context and completion, how should it be displayed?

These categories are organized in the codebase via structs and traits to implement such that contributors can easily add new features.

Use Cases

Provides a large surface area of good-first-issues to improve the DX of Wing

Implementation Notes

This issue effectively requires https://github.com/winglang/wing/issues/1779, because without some testing in place contributors and maintainers may lack confidence in making LSP changes

Component

IDE Extension


  • If you are interested to work on this issue, please leave a comment.
  • Please vote by adding a 👍 reaction to the issue to help us prioritize.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #1779, which this work depends on, then use the three completion categories in this specification to inspect the LSP implementation. Done means establishing an extensible structs-and-traits architecture for detecting contexts, generating completions, and displaying them, but this issue names no files or tests to run.

Written by the indexing model from the issue text.

Assessment

Domain
developer-experience, tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.