Images in symlinked folders do not generate thumbnails WHEN the follow_symlinks option is omitted
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 6.4k
- Forks
- 315
- PR merge metrics
- No merged PRs in 30d
Description
Symlinks have a strange quirk when the follow_symlinks option is omitted: When you navigate to a folder symlink that has images (or perhaps also other types of files), these images will not have their thumbnails generated.
This is very easy to test, just create a symlink (Via a Linux machine :p) to a folder with pictures, and you will see what I'm talking about.
Symlinks still work when the option is omitted, only I noticed this problem. I cannot fully explain why it properly lists files but refuses to generate thumbnails. Perhaps the follow_symlinks option should be the default behavior? I cannot really imagine someone not wanting symlinks to work properly.
I checked the code a bit and I cannot compile it myself unfortunately (The makefile isn't working properly). It probably has something to do with lines 2011-2012 in sshfs.c:
if (sshfs.transform_symlinks)
transform_symlink(path, &link);
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sshfs.c around lines 2011-2012 and reproduce the issue with a Linux-created symlink to a folder containing images while follow_symlinks is omitted. Trace the symlink path handling and verify that thumbnails are generated for images reached through the symlink without changing the intended behavior for other symlink cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100