windmill-labs / windmill-labs/windmill

feature: Add confirm edit option for Ag Grid (or ability to control newChange event)

Open
#3,571 0 comments 1 reaction 1 assignee View on GitHub

@rubenfiszel is already working on this.

Since Apr 17, 2024.

Dominant language
Rust
Stars
18k
Forks
1.1k
Avg merge
1d 1h
Merged PRs (30d)
328

Description

Imagine you have an app with several Ag Grid tables. You've been asked to add a "Are you sure you want to edit this cell?" confirmation anytime someone edits a cell value. If !confirm, you want to cancel the change and revert the cell contents. If yes, you would like to proceed with firing the newChange event for subscribers to process.

I would like to request (Ideally) for there to be a modal confirmation option with Ag Grid for editing such that canceling reverts the cell value and stops editing. And confirming fires the NewChange event.

Alternatively, allow developers to control the edit newChange event so that they can implement their own confirmation workflow.

Thank you. 🙏

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.