winapps-org / winapps-org/winapps
new setup.sh behaviour breaks installing/reinstalling from a local custom fork
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 16k
- Forks
- 508
- Avg merge
- 13h 35m
- Merged PRs (30d)
- 3
Description
The new behaviour of setup.sh is super unfriendly.
Running setup just re-clones the main repo to ~/.local/winapps-src and intalls from there - regardless of the repo being cloned locally already.
Not only is this doubling up on cloning, but BIG issue here is when you are wanting to install winapps from a custom local fork for testing . The current behaviour effectively ignores all local code, which forces all custom changes to be manually re-added each and every time setup is run.
I really think that setup should try to install from any local repo source first and certainly not ignore or overwrite customisations made to any local code. (This nearly caught me out testing a new PR, as I was thinking I was testing my own new code and all the while I wasn't testing anything new. )
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with setup.sh and trace how it selects the repository source and installs into ~/.local/winapps-src. Reproduce a setup or reinstall from a local custom fork, then verify that the local changes are used and are not overwritten; the issue does not mention a specific test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100