willowtreeapps / willowtreeapps/vocable-android
Combine EditPhrasesKeyboardFragment and AddPhraseKeyboardFragment
Open
@lauren-ahart is already working on this.
Since May 14, 2024.
- Dominant language
- Kotlin
- Stars
- 127
- Forks
- 21
- Avg merge
- 16m
- Merged PRs (30d)
- 4
Description
These fragments are both subclasses of EditKeyboardFragment, and have very similar functionality. EditPhrasesKeyboardFragment should be able to handle both jobs, with the following changes:
- Add a boolean nav arg that identifies whether a phrase is being added (a var already exists in the fragment for this, but its value is always
false) - Pass the appropriate value for said nav arg when editing vs. adding a new phrase (tapping existing phrase or using
+button) - Alter nav graph so that the
+button on EditCategoryPhrasesFragment opens an Edit fragment instead of an Add fragment - Add the function
addPhraseto EditPhrasesViewModel: see AddPhraseViewModel - Probably replace use of deprecated ILegacyCategoriesAndPhrasesRepository in PhrasesUseCase (may be best broken out into future work)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.