willowtreeapps / willowtreeapps/vocable-android

Pagination label does not adjust correctly as categories are added and deleted from list

Open
#382 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Kotlin
Stars
127
Forks
21
Avg merge
16m
Merged PRs (30d)
4

Description

Description:

While adding and deleting categories from the Settings > Categories and Phrases list screen, the pagination label does not adjust as expected when going from 1 to 2 pages or 2 to 1 page. The page left/right buttons will disable and enable as expected, but the "Page X of Y" label does not.

Some of this behavior may be related to the root cause of bug #381 . So, depending on which issue is fixed first, the other may need to be re-tested after, to try and reproduce.

Steps To Reproduce:

  1. Navigate to Settings > Categories and Phrases
  2. Delete categories until there is only one page to display; note the behavior of the pagination label
  3. Add a new category(ies) to the list so that there are now two pages.
  4. On a tablet, you may need to reverse the order of steps 2 and 3 (add categories first, deleting categories second)

Expected behavior
As the number of categories adjusts so that the number of pages adjust from 1 to 2 and 2 to 1 , the pagination label displays "Page 1 of 2" and "Page 1 of 1" accordingly.

Actual Behavior
-> When deleting categories, once there is only one page to display the pagination label will display "Page 1 of 2" and then disappear.
-> When adding categories, the pagination label will not appear (remain missing) as the number of pages grows from 1 to 2.

Devices:

  • Pixel 5 phone and Nexus 10 tablet (both emulated)
  • Android 12 (both devices)

Screenshots
1 VocableAndroid_addingNewCategories_deleting_from_twoToOne_page

2 VocableAndroid_addingNewCategories_from_oneToTwo_pages

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on the Settings > Categories and Phrases list with the Android 12 phone or tablet scenarios described. Trace where the pagination label updates as categories move between one and two pages; done means it shows "Page 1 of 2" and "Page 1 of 1" correctly after additions and deletions.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.