willowtreeapps / willowtreeapps/vocable-android

Categories List Screen Does Not Display Pagination Label For Single Page

Open
#381 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Kotlin
Stars
127
Forks
21
Avg merge
16m
Merged PRs (30d)
4

Description

Description:

When viewing the Settings > Categories and Phrases > categories list screen, if there are only enough categories for one page then the pagination label is not displayed. For consistency with the rest of the app, there should be a "Page 1 of 1" label displayed between the page left/right buttons.

Reproduced on develop.

Steps To Reproduce:
Phone:

  1. Assuming more than 2 categories in the app...
  2. Navigate to Settings > Categories and Phrases
  3. Delete categories until only enough remain that there is only one page of categories
  4. Note that the pagination label is missing

Tablet:

  1. Rotate the device to been in portrait
  2. Navigate to Settings > Categories and Phrases
  3. Note that the pagination label is missing
  4. Rotate the device to be in landscape
  5. Delete categories until only enough remain that there is only one page of categories
  6. Note that the pagination label disappears

Expected behavior
The pagination label remains and displays as "Page 1 of 1"

Actual Behavior
The pagination label is missing/removed. Even if you rotate your device so that there are more than multiple pages, once you return to a single page the label will disappear if you leave and return to the screen.

Devices:

  • Pixel 5 phone, Nexus 10 tablet (both emulated)
  • Android 12 (both)
  • reproduced on develop

Screenshots
VocableAndroid_CategoriesListScreen_paginationMissingLabel

2 VocableAndroid_CategoriesListScreen_paginationMissingLabel

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue on develop in the Settings > Categories and Phrases categories list screen, using the phone and tablet steps described. Trace the pagination controls and label for a single-page category list, including after rotation and returning to the screen. Done means the label remains visible and reads "Page 1 of 1" when only one page is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.