willnorris / willnorris/imageproxy
better support of caching headers
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4k
- Forks
- 513
- PR merge metrics
- No merged PRs in 30d
Description
notably, we don't do anything directly with the Cache-Control. The httpcache library handles respecting upstream directives in terms of what gets cached, but we don't set any Cache-Control directives on downstream responses.
@shepik, I see that you rewrote part of the httpcache library in 781938ac22a3bcabeb7c7e1b5f36d857afd93084, but I haven't yet looked closely at what you changed. Were these custom changes for something you're doing, or are these things that should be considered for inclusion upstream?
also /cc @jelinden who added Cache-Control support in e41beef55bf8fbfc1aeb35d296df06d2b4cb6a71 for cloudfront. I'm not sure that we want to hard-code a max-age, as opposed to respecting the max-age from upstream, but I'd be curious to hear what cloudfront needs in this regard.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the referenced httpcache rewrite at commit 781938ac22a3bcabeb7c7e1b5f36d857afd93084 and the CloudFront Cache-Control change at e41beef55bf8fbfc1aeb35d296df06d2b4cb6a71. Clarify the desired downstream directives and upstream max-age behavior before identifying the implementation and validation needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100