willnorris / willnorris/imageproxy
Overriding user agent when fetching remote images fails in latest main
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4k
- Forks
- 513
- PR merge metrics
- No merged PRs in 30d
Description
We were using the latest docker image (digest: e3e4a1c09a4c) published a few days ago and trying to override the user agent string using the userAgent config option. But using this option, we failed to fetch image using the image proxy against a site that restricts image fetching without user agent being set, f.e. check this image
However, downgrading to docker image version v0.10.0 works fine. So presume recent changes since v0.10.0 or a third party library use or version upgrade may be causing the issue here. I did quickly go over the code commits but nothing struck out to me as suspect though. Filing this issue to report. But please let me know if you are unable to reproduce this issue with latest code in main branch and I can try without docker container and reproduce again. Thank you!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the image proxy's userAgent config option and reproduce the reported fetch against the linked Kansas City image using the latest main Docker image, then compare it with v0.10.0. Trace the user-agent value through the remote image request and identify whether a recent change or dependency prevents it from being sent; done means the configured user agent allows the image to be fetched again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100