getScript/getDir/isRtl return incorrect data for unrecognised codes containing a script tag
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- localization
Research direction
Locate the implementations of getScript, getDir, and isRtl in the language-data codebase and inspect how they handle codes that are not defined. Use the issue's mis-arab example as the starting case. Done means these functions derive the Arabic script and right-to-left direction from the script tag, returning Arab, rtl, and true respectively.
Written by the indexing model from the issue text.
Description
If a language code contains a script tag, getScript, getDir and isRtl should not need the code to be defined, because it already contains the information they need.
e.g. For mis-arab (uncoded language, Arabic script):
$.uls.data.getScript("mis-arab"); currently returns Zyyy instead of Arab.
$.uls.data.getDir("mis-arab"); currently returns ltr instead of rtl.
$.uls.data.isRtl("mis-arab"); currently returns false instead of true.
- Dominant language
- PHP
- Stars
- 18
- Forks
- 37
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from wikimedia/language-data
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
wikimedia/language-data#499 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
wikimedia/language-data#459 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
wikimedia/language-data#412 · 7 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
wikimedia/language-data#372 · 9 comments ·
-
Add sign languages Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
wikimedia/language-data#293 · 1 comment ·
All issues in wikimedia/language-data
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getgrav/grav-plugin-api#45 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
RSS-Bridge/rss-bridge#5098 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
phingofficial/phing#2025 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
silverstripe/developer-docs#911 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100