widgetti / widgetti/solara

ToggleButtonSingle adds buttons twice

Open
#232 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2.2k
Forks
202
Avg merge
4h 36m
Merged PRs (30d)
3

Description

If you use the example in the docs of setting custom buttons, the widget adds the buttons twice.

Line 87 in togglebuttons.py is

children = [solara.Button(label=str(value)) for value in values] + children

but should be

    if len(children) == 0:
        children = [solara.Button(label=str(value)) for value in values]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in togglebuttons.py at line 87 and reproduce the issue using the custom-buttons example from the documentation. Confirm that ToggleButtonSingle renders the provided buttons only once when custom children are supplied; the issue is done when the duplicate buttons no longer appear.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
frontend
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.