widgetti / widgetti/ipyvuetify

Styles are still loaded even when Jupyterlab's --future-skip-styles-for-disabled flag is used

Open
#244 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

maintenance
Dominant language
Python
Stars
355
Forks
61
PR merge metrics
No merged PRs in 30d

Description

TLDR - styles are still loaded even when the lab extension is disabled and Jupyterlab's --future-skip-styles-for-disabled flag is used.

Jupyterlab 3.6.0 recently introduced an option --future-skip-styles-for-disabled to avoid loading styles of disabled extensions. This flag is about to become the default in Jupyterlab 4.0 - see section "Future changes" here. This is a much-anticipated step in addressing the performance issues of Jupyterlab.

However, when I disable jupyter-vuetify and start Jupyterlab 3.6.1 using the flag described above, I can see that the styles of this extension are still loaded onto the page, since the styles are loaded directly in this line - link while Jupyterlab's recommendation seems to be to define the location of CSS in package.json - link

Seeing this is incompatible with a Jupyterlab option that is about to become default, can this be fixed please?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with js/src/index.js, where the stylesheet is loaded directly, and compare it with the JupyterLab CSS file-organization guidance and package.json. Rework the extension's style declaration so JupyterLab can skip it when the extension is disabled, then verify with JupyterLab 3.6.1 and --future-skip-styles-for-disabled that the styles are no longer loaded.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, jupyter
Domain
frontend, performance
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.