whitesmith / whitesmith/rubycritic

Remove dependencies between analysers

Open
#90 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

internal
Dominant language
Ruby
Stars
3.5k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

I took a brief pass at trying to add an --only option to restrict certain analysers from running, but it seems that there is some dependencies between the analysers during a run that I fully grok yet.

For reference, my initial attempt at adding an --only option https://github.com/jbodah/rubycritic/commit/8d54cea734bc4bc1fd86f2130dd24a899e76d275

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked commit, 8d54cea734bc4bc1fd86f2130dd24a899e76d275, and trace the analyser dependencies it exposed. Done means analysers no longer depend on one another during a run, allowing an --only option to restrict which analysers execute.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.