whitesmith / whitesmith/rubycritic

Extract SourceControl subdirectory to gem?

Open
#64 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

discussion internal
Dominant language
Ruby
Stars
3.5k
Forks
234
PR merge metrics
No merged PRs in 30d

Description

Hey @guilhermesimoes or whoever else is working on rubycritic these days!

I've continued working on Debt Ceiling off and on the last year or so, and just finished a v1 of a big new feature... It adds/requires additional git/source control dependency, and while I considered using rugged, I decided to look at what you guys did for git code and liked your source control abstraction as a light weight interface with no additional dependencies...

For now I just copy pasted your code into my repo and built some new features on it, but I wondered if you would be open to/interested in making it into a new shared gem we can both rely on together? Or, it just occurred to me to see if anyone else already has a ruby source control abstraction, we might both be able to rely on this scm gem I just found, but my addition to your library would need to be ported to theirs, and I think will only work for git... Curious for thoughts/reactions, the PR with my changes to your code are here starting with base.rb, but missing implementation for travel_to_commit for mercurial, and some test coverage. Just an initial feeler while I ponder next steps.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked Debt Ceiling pull request, especially the changes beginning with base.rb, and compare them with Rubycritic's existing SourceControl code. Check the missing travel_to_commit implementation for Mercurial and the stated test-coverage gap. Done would require a decided extraction or integration plan, including compatible implementations and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.