whatwg / whatwg/html

closedby=closerequest should be closedby=close-request

Open
#11,331 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic: dialog
Dominant language
HTML
Stars
9.4k
Forks
3.2k
PR merge metrics
PR metrics pending

Description

What is the issue with the HTML Standard?

TAG's Casing Rules state that enumerated values for attributes should be lowercase, dash-delimited.

closedby=closerequest is not dash-delimited. Admittedly this completely flew by me while implementing it in Firefox until just now, when we're imminently shipping.

Perhaps we can change this? Perhaps we can do so safely by keeping around the closerequest value but deprecating it? What are people's thoughts?

/cc @mfreed7 @smaug----

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the HTML Standard's definition of the closedby attribute and the linked TAG Casing Rules. Determine whether closerequest should be replaced by close-request and whether the existing value needs a deprecation or compatibility path; the issue does not name a file or test, so completion depends on resolving that design question.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.