wharfkit / wharfkit/contract

Option to set the `json: false` flag on `get_table_rows` back to `true`

Open
#28 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

For debugging and maybe specific use cases, it would be good if the json flag on the table query could be set back to true.

Right now its hardcoded in two places to false.

https://github.com/wharfkit/contract/blob/405bee17ec1a08d1903687d3a68e8d077a387ab0/src/contract/table.ts#L148

https://github.com/wharfkit/contract/blob/405bee17ec1a08d1903687d3a68e8d077a387ab0/src/contract/table-cursor.ts#L111

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/contract/table.ts at line 148 and src/contract/table-cursor.ts at line 111, where the json flag is hardcoded to false. Trace how get_table_rows options are passed through these entry points, then verify that callers can request json: true while the existing default behavior remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.