wfxr / wfxr/forgit

Fish completions aren't showing the flags of the subcommands correctly

Open
#371 6 comments 0 reactions 1 assignee View on GitHub

@cjappl is already working on this.

Since Mar 20, 2024.

Dominant language
Shell
Stars
5.1k
Forks
166
Avg merge
1d 11h
Merged PRs (30d)
5

Description

Environment info

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:
  • Shell
    • bash
    • zsh
    • fish

Problem / Steps to reproduce

Full fish completions are relatively new, but some of them are behaving strangely.

Ideally, when you do something like

gbl --<TAB>

You get all the flags available to pass into git blame:

> git blame --help
--contents  (Instead of working tree, use the contents of the named file)  --line-porcelain                     (Show the porcelain format)  --show-email  (Show the author email instead of author name)
--date                        (Specifies the format used to output dates)  --porcelain  (Show in a format designed for machine consumption)  --show-name       (Show the filename in the original commit)
--help                                  (Display manual of a Git command)  --reverse             (Walk history forward instead of backward)  --show-number  (Show the line number in the original commit)
--incremental                             (Show the result incrementally)  --root                 (Do not treat root commits as boundaries)  --show-stats                 (Include additional statistics)

Instead you get:

> git-forgit blame --

Nothing.

It seems like we are completing the files correctly, but not wrapping the flags. Filing this for the future

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.