wemake-services / wemake-services/wemake-python-styleguide
Simplify if elif (two cases)
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.9k
- Forks
- 430
- Avg merge
- 5h 14m
- Merged PRs (30d)
- 34
Description
is there a rule that makes you write like this?
wrong:
if action == 'disable':
is_disable = True
elif action == 'enable':
is_disable = False
correct:
is_disable = True if action == 'disable' else False
or
is_disable = action == 'disable'
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or rule entry point. Start by reviewing existing rules for boolean assignments and conditional expressions, then determine whether this pattern is intended to receive a lint rule. Done should include an agreed rule scope and corresponding tests, but the issue does not define either.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100