webcomponents / webcomponents/polyfills

Setting ShadyDOM settings via `ShadyDOM` object and URL flags are incompatible.

Open
#250 2 comments 0 reactions 1 assignee Claimed by @sorvell View on GitHub
Focus Area: Standards & Polyfills Package: shadydom Type: Bug wontfix
Dominant language
HTML
Stars
1.2k
Forks
168
PR merge metrics
No merged PRs in 30d

Description

Loading the polyfill bundle with URL flags is not compatible with using the object syntax to force ShadyDOM on.

In particular, if you do `ShadyDOM = {force: true, noPatch: true}` and then load the page with `?wc-shadydom=true` then `noPatch` is set to off because it's read off the URL in this case. It should fall back to its current value.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.