web-platform-tests / web-platform-tests/wpt
Have lints for as much as possible
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 6.2k
- Forks
- 3.9k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 586
Description
Originally posted as https://github.com/w3c/wpt-tools/issues/154 by @gsnedders on 31 Jan 2017, 07:24 UTC:
@patrickkettner was correctly pointing out that we should, ideally, have lints for almost everything we have rules about. Some things we're missing:
- reftests shouldn't have a canvas larger than the standard viewport
- generate_tests shouldn't be used
- linked resources should exist (we might need some way to have inline whitelisting for this, because I don't think the global whitelist would scale for
<img src=non-existant-file>and similar?)- files should either declare their encoding or be ASCII
- files should be valid (or, at the very least, contain no parse errors)
- manual tests if they use testharness.js should have an explicit timeout
- vendor prefixes aren't used
- complex assertion in assert_true
- setTimeout used (esp. with short time)
.worker.jstests should importtestharness.js..any.jstests should not importtestharness.js.- catch basic cases of external URLs
There was also the discussion about whether we should require more when it comes to code-style, though that's likely something for the mailing list.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by reviewing the existing linting system and the listed missing checks, then clarify which rules are in scope. Done requires an agreed scope and lint coverage for the selected rules.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- css, html, javascript
- Domain
- testing, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100