web-platform-tests / web-platform-tests/wpt

[scroll-animations] multiple issues with `animation-timeline` and the `animation` shorthand

Open
#43,500 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

scroll-animations
Dominant language
HTML
Stars
6.2k
Forks
3.9k
Avg merge
1d 6h
Merged PRs (30d)
586

Description

While looking at adding support for the various CSS properties relevant to Scroll-linked Animations, I came across these tests which look incorrect to me:

https://github.com/web-platform-tests/wpt/blob/e8d57f52b64b733a0927503ed31b8e4e9c7100a7/css/css-animations/parsing/animation-computed.html#L20-L38

This test does not match the CSS Animations Level 2 grammar for animation-timeline since the final value <single-animation-timeline> is not serialized. I realize that this test is perfectly valid for implementations that support CSS Animations Level 1, but how should we deal with the expansion of the animation shorthand?

https://github.com/web-platform-tests/wpt/blob/e8d57f52b64b733a0927503ed31b8e4e9c7100a7/scroll-animations/css/animation-shorthand.html#L18-L21

This test assumes scroll() and view() are not valid values for animation-timeline but they are. This seems like a straight up bug that I'd be happy to file a PR for.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with css/css-animations/parsing/animation-computed.html and scroll-animations/css/animation-shorthand.html at the referenced lines, then compare their expectations with the CSS Animations Level 2 grammar. Update the tests so animation-timeline serialization and scroll()/view() validity match the specification, and run the relevant WPT tests to confirm the corrected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, html
Domain
testing, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.