weaviate / weaviate/weaviate-python-client
Batch import doesn't apply rate limit when using async indexing
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 227
- Forks
- 151
- Avg merge
- 3d 14h
- Merged PRs (30d)
- 11
Description
Using the Python client in its version 4.10.4
The function rate_limit is not working if Weaviate is configured in async indexing mode:
with open(dataset_path, "r") as f:
collection.batch.rate_limit(100)
with collection.batch.dynamic() as batch:
for raw_json_email in f:
email = json.loads(raw_json_email)
batch.add_object(
properties=email["data"],
uuid=email["id"],
)
The batches have 1000 objects, no mater the rate configured.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing collection.batch.rate_limit and the collection.batch.dynamic() path in the Python client, then reproduce the reported behavior with async indexing enabled using the issue's example. Confirm whether the configured limit is applied during batch import; done means batches no longer default to 1000 objects when a different rate is configured.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100