weaviate / weaviate/weaviate-cli

Allow query_data to return blob properties

Open
#162 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
31
Forks
19
PR merge metrics
No merged PRs in 30d

Description

Context

Currently, when data is queried we just get all properties. This excludes blob properties so that the grpc message isn't overloaded.
We should add, to each query type, the retrun_properties parameter and pass the user's property list forward as needed. Currently the property list is not in the correct format.

location to start fixes: https://github.com/weaviate/weaviate-cli/blob/7734fe3c46a3fceca1cb8fd1d2abae8c50cb2c65/weaviate_cli/managers/data_manager.py#L1356

Scope
  • add return_properties to query data and fix resulting breaks
Files Involved

https://github.com/weaviate/weaviate-cli/blob/7734fe3c46a3fceca1cb8fd1d2abae8c50cb2c65/weaviate_cli/managers/data_manager.py#L1356

Acceptance Criteria
  • query data can retrieve coverImage property
  • no other functional regressions
Constraints

No response

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in weaviate_cli/managers/data_manager.py at line 1356 and trace query_data through each query type. Check how the user's property list is currently formatted and how it is forwarded, then verify that querying can return the coverImage blob property without causing other query regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.