URLError and socket.error are expected, but only partially handled
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 115
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
If revocation mode is not "soft-fail", URLError and socket.error are reraised from context.retrieve_crls:
and from context.retrieve_ocsps:
Callers (validate.verify_crl, validate.verify_ocsp_response, and finally validate._validate_path) don't handle these errors, so they may escape from certvalidator, which is probably not intentional and is not documented.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read context.retrieve_crls and context.retrieve_ocsps alongside validate.verify_crl, validate.verify_ocsp_response, and validate._validate_path. Trace how URLError and socket.error propagate when revocation mode is not "soft-fail", then determine the intended handling and documentation; the issue is complete when that behavior is consistent and documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100