wavesplatform / wavesplatform/gowaves
Continue working on PR #1966
Open
Nobody has claimed this yet.
ready
- Dominant language
- Go
- Stars
- 251
- Forks
- 73
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 28
Description
Summary
Continue working on PR #1966.
- Create a branch derived from
fix-semgrep-issues-2branch. - Create a new PR with the
fix-semgrep-issues-2as a base branch. - Fix all code related issues found with
semgrep. - To get the list of remaining issues execute the following command:
semgrep ci --config="auto" --config="r/default" --config="r/go" --config="r/dgryski" --config="r/trailofbits" --config="r/dockerfile" --config="r/bash" --config="r/problem-based-packs" --config="r/generic" --config="r/yaml" --config="r/json" --config="./.semgrep/rules" --dataflow-traces --max-target-bytes=2MB
Test plan
-
makecompletes without errors -
semgrep ci --config="auto" --config="r/default" --config="r/go" --config="r/dgryski" --config="r/trailofbits" --config="r/dockerfile" --config="r/bash" --config="r/problem-based-packs" --config="r/generic" --config="r/yaml" --config="r/json" --config="./.semgrep/rules" --dataflow-traces --max-target-bytes=2MBreturns only semgrep configuration related warnings.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PR #1966 and the fix-semgrep-issues-2 branch, then run the semgrep command listed in the issue to identify the remaining findings. Check the repository's existing changes and run make as work progresses. Done means the remaining findings are only semgrep configuration warnings and make completes without errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100