wavesplatform / wavesplatform/Waves

kamon.metric.Timer warns about negative values due to NTP time sync

Open
#3,480 7 comments 0 reactions 1 assignee View on GitHub

@phearnot is already working on this.

Since May 18, 2021.

bug
Dominant language
Scala
Stars
1.2k
Forks
428
Avg merge
12h 22m
Merged PRs (30d)
4

Description

We still (on the newest node 1.3.4) get errors like these:
WARN [ecution-context-global-XX] kamon.metric.Timer - Failed to record value [-70000000] on [span.processing-time,{operation=block-appender,error=false}] because the value is outside of the configured range. The recorded value was adjusted to the highest trackable value [3600000000000]. You might need to change your dynamic range configuration for this metric

This is not just annoying to see (was reported many times for years) but this also means the code executes and spends CPU cycles on non active functionality:

kamon.enable = no
kamon.modules.influxdb-span-reporter.enabled = no
metrics.enable = no

Because metrics calls (as far as i understand) are unconditional (for example just search for measureSuccessful)

Please, for god sake, make these metrics completely turned off by metrics.enable = no and i mean off = check config once and don`t waste CPU cycles anymore on that.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.