wavefnd / wavefnd/Wave

Reject empty values passed to --dep-root

Open Beginner friendly
#649 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue
Dominant language
Rust
Stars
53
Forks
16
Avg merge
4h 22m
Merged PRs (30d)
46

Description

## Current evidence

`src/cli.rs` rejects an empty value in the `--dep-root=` form, but the separate `--dep-root ` branch pushes the following argument directly into `g.dep.roots` without checking whether it is empty or whitespace-only.

The two spellings of the same option therefore have different validation behavior.

## Scope

- Apply the same non-empty validation to both `--dep-root=` and `--dep-root `.
- Treat whitespace-only values as missing values.
- Preserve valid relative and absolute dependency-root paths.
- Do not add filesystem-existence requirements to this task.

## Completion criteria

- CLI tests cover empty and whitespace-only values for both option spellings.
- Valid values continue to populate dependency roots unchanged.
- Invalid values use the existing CLI usage-error path and message style.

Contributor guide

Open the contributing guide

Research direction

Start in src/cli.rs and inspect the separate-argument branch alongside the existing --dep-root= validation. Run the existing CLI tests, then add coverage for empty and whitespace-only values in both spellings while checking that valid relative and absolute paths remain unchanged and invalid inputs use the existing usage-error style.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
86/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.