warpdotdev / warpdotdev/warp

ssh autocomplete for fish shell no longer works

Open
#4,961 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:ssh bug ready-to-implement triaged
Dominant language
Rust
Stars
65.1k
Forks
5.6k
PR merge metrics
PR metrics pending

Description

Dupe Check
Describe the bug

Recently SSH autocompletion with my fish shell worked fine, something broke it in the past week or so. This is mainly a rubber ducking thread and I'll post my results here. This might be a fish issue, might be a warp issue. But I do know that if I open a non-Warp shell then SSH autocompletion works as expected.

To reproduce

type ssh then <TAB>. A list of IP addresses appear, but no hostnames. It appears that it does list suggestions IF the hostname is in ~/.ssh/config but NOT any Include <path>/* directives.

Expected behavior

List of hosts in ~/.ssh/config to return.

Screenshots

No response

Operating system

MacOS

Operating system and version

14.5 (23F79)

Shell Version

fish, version 3.7.1

Current Warp version

v0.2024.05.14.08.01.stable_04

Regression

Yes, this bug started recently or with an X Warp version

Recent working Warp date

No response

Additional context

No response

Does this block you from using Warp daily?

No

Is this a Warp specific issue? (i.e. does it happen in Terminal, iTerm, Kitty, etc.)

Yes, this I confirmed this only happens in Warp, not other terminals.

Warp Internal (ignore): linear-label:b9d78064-c89e-4973-b153-5178a31ee54e

None

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing ssh plus Tab in Warp using fish 3.7.1 on macOS 14.5, then compare its suggestions with a non-Warp terminal and inspect how SSH host entries from ~/.ssh/config and Include directives are discovered. Done means included hostnames appear in Warp's autocomplete as they do elsewhere.

Written by the indexing model from the issue text.

Assessment

Tech stack
fish, macos
Domain
cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.